Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JsonbMapType reporting their type appropriately #67

Closed
wants to merge 1 commit into from

Conversation

tmarthal
Copy link
Contributor

Use jsonb with a dbCreate='validate'
When using a JsonbMapType class and dbCreate='validate' with the current plugin, the following happens:

nested exception is org.hibernate.HibernateException: Wrong column type in term.stanson_code for column code. Found: jsonb, expected: json

This is because the JsonbMapType is a child class of JsonMapType and the sqlTypes method is not being overridden correctly.

Here is an example:

Domain Class:

    // The key/value json blob
    Map code
    static mapping = {
        code type: JsonbMapType
    }

Using update, this will NOT complain that the 'jsonb' and 'json' types do not match. We can see that the JsonbMapType is reporting the wrong type when the schema is exported:

$> ./grailsw schema-export; cat target/ddl.sql | grep json

Before:

code json not null,

With the code in the pull requesT:

code jsonb not null,

@coveralls
Copy link

Coverage Status

Coverage increased (+0.04%) to 73.98% when pulling 0d84d18 on tmarthal:master into 1b90d71 on kaleidos:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage increased (+0.04%) to 73.98% when pulling 0d84d18 on tmarthal:master into 1b90d71 on kaleidos:master.

@ilopmar
Copy link
Collaborator

ilopmar commented May 19, 2015

Thank you very much for the PR. I'm busy right now but I promise that I'll review all the pending PRs and release a new version during the GR8Conf Hackergarten in two weeks.

@ilopmar
Copy link
Collaborator

ilopmar commented Jun 2, 2015

Merged!

Thank you very much 👍

@ilopmar ilopmar closed this Jun 2, 2015
ilopmar added a commit that referenced this pull request Jun 2, 2015
@ilopmar
Copy link
Collaborator

ilopmar commented Jun 2, 2015

Included in version 4.5.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants