JsonbMapType reporting their type appropriately #67
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use jsonb with a dbCreate='validate'
When using a JsonbMapType class and
dbCreate='validate'
with the current plugin, the following happens:nested exception is org.hibernate.HibernateException: Wrong column type in term.stanson_code for column code. Found: jsonb, expected: json
This is because the JsonbMapType is a child class of JsonMapType and the
sqlTypes
method is not being overridden correctly.Here is an example:
Domain Class:
Using update, this will NOT complain that the 'jsonb' and 'json' types do not match. We can see that the JsonbMapType is reporting the wrong type when the schema is exported:
$> ./grailsw schema-export; cat target/ddl.sql | grep json
Before:
With the code in the pull requesT: