Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for more generic json/jsonb criteria #95

Merged
merged 1 commit into from
Nov 3, 2016

Conversation

Sabst
Copy link

@Sabst Sabst commented Aug 21, 2016

This is a possible approach to make criteria more flexible.
Another syntax could group the 3 first items together ("data->>name" instead of "data", "->>", "name"). I don't think this will make the approach less generic but will change a bit more PgJsonExpression.java (I was unsure about the findColumns call).

This relates to #56

Note: I also tried to see if that helped for #91 but could not find an answer: maybe a projection using PG json functions is needed...

@coveralls
Copy link

coveralls commented Aug 21, 2016

Coverage Status

Coverage increased (+0.1%) to 80.495% when pulling 92cf99b on Sabst:feature/56/json_operators into 5db768a on kaleidos:grails-2.x.

@ilopmar
Copy link
Collaborator

ilopmar commented Nov 2, 2016

I've been reviewing this and ported it to Grails 3. I'll merge it tomorrow and release a new version for Grails 2 and another one for Grails 3 with this changes.

Thank you very much for your contribution!

@ilopmar ilopmar merged commit 92cf99b into kaleidos:grails-2.x Nov 3, 2016
@ilopmar
Copy link
Collaborator

ilopmar commented Nov 3, 2016

Published version 4.6.2 for Grails 2.

@ilopmar
Copy link
Collaborator

ilopmar commented Nov 3, 2016

And also release 4.6.8 for Grails 3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants