Update GitHub actions #7
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's very important to make sure the master and standby master are synchronized before running Initialize and Execute. This is because Revert will rsync the standby master data directory onto the master data directory which can cause severe master corruption if the standby master not up-to-date. We have this check for GPDB 6X+ but it was seemingly missed for 5X because the catalog view gp_stat_replication does not exist on 5X. However, we're only checking the master and standby master replication status so there's no need to use the cluster-wide gp_stat_replication view; we can simply use pg_stat_replication which will only report the replication status of the individual segment (in this case, just the master segment).
We already check that the cluster is synchronized when creating the source cluster config file at the beginning of Initialize. However, the state of the source cluster could have changed any time afterwards between that early Initialize step and upgrading the master segment in Execute. If the cluster was out-of-sync and we run Revert after Execute, there is potential for severe catalog corruption. In particular, this is more likely to happen to the master and standby master since there's a GPDB-specific mechanism to bypass the synchronous WAL replication when the standby master is not responsive. To prevent this, we add a quick sanity check for cluster synchronization before the Initialize pg_upgrade checks and more importantly before doing the actual upgrade operation in Execute.
Pass the DUMP_PATH environment variable with the path to the dump file when making the functional pipeline such as `make DUMP_PATH=dump/5X/dump.sql.xz functional-pipeline`
Set max_statement_mem to be half of the total memory, and set statement_mem to be 1/16th of the max_statement_mem. For an n2-standard-16 instnace with 64GB of memory this sets max_statement_mem to 32GB and statement_mem to 2GB.
Ensure resource filenames are unique with git branch name to avoid collisions when multiple pipelines are run. Specify BranchName and resource filenames during pipeline creation since the Concourse GCS resource does not guarantee pulling the latest resource. See issue frodenas/gcs-resource#47
When printing the duration just pass string rather than the timer object to keep things simple. No need for the function to have access to the entire object when it's not needed.
Remove AddClusters which is no longer used. Rename add_clusters.go to for clarity.
To be consistent with the online documentation and internal naming use --upgrade-id when running `gpupgrade config show --upgrade-id`.
Keep it simple! Since upgrade ID is only ever used as a string there is no reason not to just have it be that type. It also allows us to serialize it in config.json as a string rather than a random number making it easy to correlate and debug on customer systems.
Add yearMonthDay to filename format.
Show coverage in unit and integration output.
The previous version of golangci/golangci-lint-action@v2 was showing the following warning: Warning: The `save-state` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
kalensk
force-pushed
the
updateGithubActions
branch
from
5fa6e6b
to
ecd853f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
testing 123