Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SEP-0010 JavaScript Client Reference Implementation #111

Open
1 of 3 tasks
ElliotFriend opened this issue Aug 13, 2021 · 5 comments
Open
1 of 3 tasks

SEP-0010 JavaScript Client Reference Implementation #111

ElliotFriend opened this issue Aug 13, 2021 · 5 comments

Comments

@ElliotFriend
Copy link
Collaborator

ElliotFriend commented Aug 13, 2021

Link the bounty file

https://github.com/tyvdh/stellar-quest-bounties/blob/main/bounties/level-2/sep10-javascript-client.md

Mark your progress

  • 🔵  Started working
  • 🟢  Ready for review
  • 🟣  Review completed

Provide relevant details

Going to try this one in TypeScript, to get my hands dirty with it. Wish me luck 😄

GitHub Repository: https://github.com/ElliotFriend/cuddly-eureka https://github.com/ElliotFriend/furry-octo-spork

@ElliotFriend
Copy link
Collaborator Author

I may have bitten off more than I can chew with the whole TypeScript thing, here... Back to my (mediocre at best) javascript Hehe

@ElliotFriend ElliotFriend changed the title SEP-0010 TypeScript Client Reference Implementation SEP-0010 ~~TypeScript~~ JavaScript Client Reference Implementation Aug 17, 2021
@ElliotFriend ElliotFriend changed the title SEP-0010 ~~TypeScript~~ JavaScript Client Reference Implementation SEP-0010 JavaScript Client Reference Implementation Aug 17, 2021
@hanseartic
Copy link
Contributor

I may have bitten off more than I can chew with the whole TypeScript thing, here... Back to my (mediocre at best) javascript Hehe

Actually TS makes is easier... Especially because it will protect you from doing stupid things.

@ElliotFriend
Copy link
Collaborator Author

Actually TS makes is easier... Especially because it will protect you from doing stupid things.

That's what I was hoping at the outset. But, it felt way out of depth while I'm still wrapping my head around React, in general

@hanseartic
Copy link
Contributor

A tiny thing from UI. You are using a validation on the home-domain form that expects a 'internet-address' with scheme:
grafik
The red border disappears as soon as a scheme is added
grafik

@ElliotFriend
Copy link
Collaborator Author

A tiny thing from UI. You are using a validation on the home-domain form that expects a 'internet-address' with scheme:
grafik
The red border disappears as soon as a scheme is added
grafik

Thanks for catching that!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants