support latest version of ember-changeset / ember-changeset-validations

[jelhan]

This fixes two issues:

1. It adds support for latest version of ember-changeset. It does so by not relying anymore on private API but using a native getter together with the compatibility layer dependentKeyCompat for computed properties. This can be removed as soon as FormElement class of Ember Bootstrap is refactored to use tracked properties and/or to provide a different API for validation plugins. This was reported as Broken with latest version of ember-changeset / ember-changeset-validations #26.
2. It fixes a bug with validation of initial state. Ember Changeset does not validate the initial state. A property is not validated at all until a) it's set or b) validate() method is called for it (or for all properties). This conflicts with Ember Bootstrap's assumption that validation is always up to date. A form element may be shown as valid just cause no validation was run ever. This was reported as Focus out is causing incorrect display of success on form element #22.

Fixes #26 and #22.

[jelhan]

@simonihmig The current API for validation plugins does not seem to be flexible enough for common use cases. Or did I missed an obvious alternative to overriding showValidationOnHandler?

[jelhan]

Rebased after #25 has been merged.

[basz]

Hi, could it be that this change affects the displaying of nested properties element groups? After upgrading I seem to have forms not displaying errors for nested properties, while json this.changeset.errors clearly shows them to error. Same form with root properties do show the errors...

[jelhan]

Yes. That could be caused by this change. Before it was using Ember.get(), which supports nested property readings: https://github.com/kaliber5/ember-bootstrap-changeset-validations/blob/c13b1d24557abcec3eb57726af831a4617493bb1/addon/components/bs-form/element.js#L17-L20

Refactored away from that one: https://github.com/kaliber5/ember-bootstrap-changeset-validations/blob/9034f0296e03d95fb61c99733d29b515178985c3/addon/components/bs-form/element.js#L10

Haven't considered that property may be a path itself. I think we need to use get to support that. Something like:

+ import { get } from '@ember/object';

- let error = this.model?.error?.[this.property]?.validation;
+ let error = get(this, `model.error.${this.property}.validation`);

Do you have time for a bug fix?

[basz]

this seems a legit fix, as that does return the correct validation message. The field is not rendered accordingly though...