Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added missing tests for assertion of href attribute for BsNavbar #1787

Merged

Conversation

bvedad
Copy link
Contributor

@bvedad bvedad commented May 4, 2022

This issue adds tests for the existence of href attributes on the bs-navbar component.

Fixes #1550

Copy link
Contributor

@jelhan jelhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for taking care of this one!

@jelhan jelhan merged commit f2e83b7 into ember-bootstrap:master May 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add missing tests for links generated by <BsNavbar>
2 participants