Fix inline radio element used with optionLabelPath (BS3) #766
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Good catch! Was introduced by 508ae1f. Seems like we are missing test coverage for the combination of having an |
jelhan
added a commit
to jelhan/ember-bootstrap
that referenced
this pull request
Mar 5, 2019
A test for BS4 is not needed cause `inline=true` only affects rendering an additional class for that one.
simonihmig
changed the title
|
@jelhan thanks for putting the test together. I think I will merge this quickly, as the fix itself is fine and I wanted to cut a release today. Can you target your PR to the main repo's master instead? |
|
@simonihmig Sure. Please find it as #768. |
simonihmig
added a commit
that referenced
this pull request
Mar 5, 2019
test(BsForm): adds failing test for pull request #766
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've not used this part, but found something that looks like an issue while exploring the code.