Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TypeError: filename.includes is not a function #141

Open
EECOLOR opened this issue Jul 31, 2018 · 2 comments
Open

TypeError: filename.includes is not a function #141

EECOLOR opened this issue Jul 31, 2018 · 2 comments
Labels
enhancement

Comments

@EECOLOR
Copy link
Member

EECOLOR commented Jul 31, 2018

Reproduce:

  • cd example
  • yarn watch
  • cp src/bg1.jpg src/bg2.jpg

This is caused by a webpack bug: webpack/webpack#7828

We should probably build a workaround until the issue is resolved.
EECOLOR added a commit that referenced this issue Jul 31, 2018
@EECOLOR
workaround for #141
b58e62d
@EECOLOR
Copy link
Member Author

EECOLOR commented Aug 13, 2018

If we update to the latest webpack the workaround can be removed.

@EECOLOR
Copy link
Member Author

EECOLOR commented Nov 25, 2019

The workaround can be removed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@EECOLOR