Skip to content

Commit

Permalink
fix usage of --admin-login
Browse files Browse the repository at this point in the history
  • Loading branch information
gggeek committed Jun 16, 2023
1 parent d75b8af commit 47562c8
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 2 deletions.
4 changes: 2 additions & 2 deletions Core/MigrationService.php
Expand Up @@ -349,7 +349,7 @@ public function executeMigration(MigrationDefinition $migrationDefinition, $migr
* @param array $migrationContext
* @param int $stepOffset
* @param bool $useTransaction Deprecated - replaced by $migrationContext['useTransaction']. When set to false, no repo transaction will be used to wrap the migration
* @param string|int|false|null $adminLogin Deprecated - $migrationContext['adminLogin']. Used only for committing db transaction if needed. If false or null, hardcoded admin is used
* @param string|int|false|null $adminLogin Deprecated - $migrationContext['adminUserLogin']. Used only for committing db transaction if needed. If false or null, hardcoded admin is used
* @throws \Exception
*/
protected function executeMigrationInner(Migration $migration, MigrationDefinition $migrationDefinition,
Expand All @@ -363,7 +363,7 @@ protected function executeMigrationInner(Migration $migration, MigrationDefiniti

// BC: handling of legacy method call signature
$useTransaction = array_key_exists('useTransaction', $migrationContext) ? $migrationContext['useTransaction'] : $useTransaction;
$adminLogin = array_key_exists('adminLogin', $migrationContext) ? $migrationContext['adminLogin'] : $adminLogin;
$adminLogin = array_key_exists('adminUserLogin', $migrationContext) ? $migrationContext['adminUserLogin'] : $adminLogin;

$messageSuffix = '';
if (isset($migrationContext['forcedReferences']) && count($migrationContext['forcedReferences'])) {
Expand Down
6 changes: 6 additions & 0 deletions WHATSNEW.md
@@ -1,3 +1,9 @@
Version: 6.3.4
==============

* Fixed: the `--admin-login` option had been broken for `migrate` commands since version 6.3.0


Version: 6.3.3
==============

Expand Down

0 comments on commit 47562c8

Please sign in to comment.