Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow version 4 for nikic php-parser #167

Merged
merged 1 commit into from Jul 16, 2018

Conversation

crevillo
Copy link
Contributor

i'm playing with some other projects that requires this php-parser version.

do you think this could lead to some problems here? if so, please discard this.

@gggeek
Copy link
Member

gggeek commented Jul 14, 2018

I would have to take a look at how we use it... The bundle iirc uses a small part of the php-parser api, and the release notes seem to be nicely detailed (https://github.com/nikic/PHP-Parser/blob/master/UPGRADE-4.0.md), so I'd say good chances of going in as soon as I can afford a few minutes to look into it

@codecov-io
Copy link

Codecov Report

Merging #167 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #167   +/-   ##
=========================================
  Coverage     67.51%   67.51%           
  Complexity     2293     2293           
=========================================
  Files           120      120           
  Lines          6055     6055           
=========================================
  Hits           4088     4088           
  Misses         1967     1967

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2fd6962...bc942ea. Read the comment docs.

@gggeek
Copy link
Member

gggeek commented Jul 16, 2018

Ok, the usage that we do of of php-parser is minimal. Going in

@gggeek gggeek merged commit 18d1727 into kaliop-uk:master Jul 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants