Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When a job timeout, krawler hangs with the following error: Cannot read property 'type' of undefined #135

Closed
robinbourianes-kalisio opened this issue Nov 27, 2020 · 2 comments
Assignees
Labels

Comments

@robinbourianes-kalisio
Copy link
Contributor

Running hubeau krawler job with DEBUG=*, the last log entry before the crash is the following:

krawler:jobs 1970 tasks ran from start in 1800106.770962 ms +0ms
@feathersjs/errors Timeout(408): Job timeout reached +0ms
@feathersjs/errors {} +1ms
krawler:jobs Some tasks failed Timeout: Job timeout reached
at new Timeout (/hdd/robin/Taff/kalisio/krawler/node_modules/@feathersjs/errors/lib/index.js:135:17)
at Object. (/hdd/robin/Taff/kalisio/krawler/lib/jobs/jobs.async.js:81:68)
at Generator.next ()
at step (/hdd/robin/Taff/kalisio/krawler/lib/jobs/jobs.async.js:112:191)
at /hdd/robin/Taff/kalisio/krawler/lib/jobs/jobs.async.js:112:361
at runMicrotasks ()
at processTicksAndRejections (internal/process/task_queues.js:97:5) {
type: 'FeathersError',
code: 408,
className: 'timeout',
data: undefined,
errors: {}
} +1ms

Without DEBUG=* the only line we get is Cannot read property 'type' of undefined which is printed from here:

console.error(error.message)

@robinbourianes-kalisio
Copy link
Contributor Author

The type property the code tries to read is from here
Somehow throwing the timeout error from here mess up stuff in feathers.
Feathers god help requested ! @claustres

@claustres claustres self-assigned this Dec 8, 2020
@claustres
Copy link
Member

If the error hooks are removed from the job the error goes away, it is probably related to the fact some of our internal hooks do not correctly manage the error hook case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

No branches or pull requests

2 participants