Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Concurrent tasks skipped when a task fails #33

Closed
claustres opened this issue Oct 2, 2018 · 1 comment
Closed

Concurrent tasks skipped when a task fails #33

claustres opened this issue Oct 2, 2018 · 1 comment
Labels

Comments

@claustres
Copy link
Member

Steps to reproduce

Launch a job with eg 4 concurrent tasks, make one of the task fail

Expected behavior

The others tasks are correctly ran and reported to have been ran

Actual behavior

The tasks of the same concurrency bucket that should run after the failure are skipped, this is because Promise.all() here rejects with the reason of the first promise that rejects.

System configuration

Tell us about the applicable parts of your setup.

Module versions : 0.7

NodeJS version: 8

Operating System: Window

@claustres claustres added the bug label Oct 2, 2018
@claustres
Copy link
Member Author

This is actually correctly managed for fault-tolerant jobs (see https://github.com/kalisio/krawler/blob/master/src/jobs/jobs.async.js#L21). Otherwise it is normal to stop as soon as an error is raised.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant