-
Notifications
You must be signed in to change notification settings - Fork 231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hours to Show parameter not enforced #36
Comments
As @slavkobrzeg and #37 says, the timestamp is definitely not calculated correctly when using the points_per_hour option. Would be great if you could confirm this by maybe creating a |
I am definitely sure that the graph itself is fine. i compared it with my original temp graphs I have from the native thermostat app. |
The labels are getting changed in the next version, however they still scale with the set |
@kalkih : I can confirm what @slavkobrzeg mentioned - the graphs look right, just the timestamp calculations are off. |
It seems there is a fix committed to master for this already! Willing to test - but I couldn't find a test .js 'bundle' to replace the one I have installed on my raspbian-based HA install. I have "custom-updater' installed as well and refreshing it ever now and then - it is not yet seeing the new version. @kalkih would it be possible to post a 'js bundle' somewhere that includes the latest commits so we can give it shot and confirm |
@arigit Make sure to clear cache or bump the version number in the resource reference to make sure the new version loads properly. |
I works perfectly! |
Tested - all issues fixed and it looks really great |
Found another issue with the reported timestamps, this time when only part of set |
Fixed in latest v0.2.2 |
Version 0.2.1
Using these parameters:
produces this graph:
where there are actually 6 hours in display, with one point shown per hour.
Testing different value combinations is showing that the "real" number of hours that are shown is actually = hours_to_show * points_per_hour.
Increasing points_per_hour to 6, produces a graph that spans for 12 hours, even if it was supposed to be showing 2 hours. It's a very strange behavior :)
In addition, using a number < 1 for "hours to show" proudces a weird result (apparently showing an entire week or so of 'hours').
There is also a problem with the labels (too much to the left and also too tiny after reducing font_size to 60) but I think there is a merged patch that would fix that in master already
The text was updated successfully, but these errors were encountered: