Fixed incorrect value for the first point #327
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello again @kalkih,
I have noticed one issue. You were not resetting seconds and milliseconds when the endTime was set. This was resulting in slightly wrong value buckets.
This wouldn't be a big deal alone but you have this condition:
if (coords[0] && coords[0].length) coords[0] = [coords[0][coords[0].length - 1]];
For me it looks little bit hacky way of solving some specific scenario. :) IMO we should think about changing this as it works for me only because I care about max value which is always at the end of the bucket. If someone would like to take min or avg this won't work.
Example case which was failing for me:
And the result:
Take care buddy. I'm impressed how committed you are for these mini-* cards (I see update after update hehe). I use both of them! Thanks for your hard work!
Max