soft_bound config

[Silencer2K]

A new config parameter that allows to extend the boundaries when graph is out of range

[maxwroc]

Few things:

• double inline conditions are evil ;), please refactor
• you have added this option for main axis please do the same for secondary (to have consistency), I think you don't need a separate setting for it and you can reuse this one
• please update documentation

If I understand correctly you want to have a fixed bound but in case of value out of range we should render it correctly, righ?

@kalkih this seems to me like a bugfix - not a new feature, no? I'm trying to think about scenario where such hard bounds are useful but TBH nothing reasonable comes to my mind

[kalkih]

I think it could potentially be confusing for the user if the bound is specifically set but then also is dynamic, so I like the idea of having this as an option.
While I too can't find a use case where this isn't preferred, I'm sure there are, so we should keep that option available.

If it's documented well we could probably make this enabled by default though.

[kalkih]

Closes: #114

[maxwroc]

Sorry but I sustain my opinion: nested inline conditions make code not clear and hard to read. Please change it to regular if statements.

Another idea came up to my mind now: what about not adding new setting entry but allow values for bounds like: ~0. The ~ prefix would mean that this is not hard boundary . What do you think?

I would do it in the following way:

this.bound = [
    this.getBoudary("min", config.lower_bound, this.primaryYaxisSeries, this.bound[0]),
    this.getBoudary("max", config.upper_bound, this.primaryYaxisSeries, this.bound[1]),
];

getBoudary(type, configVal, series, defaultVal) {
    if (configVal === undefined) {
        // dynamic boundary depending on values
        return Math[type](...series.map(ele => ele[type])) || defaultVal
    }

    if (configVal[0] != "~") {
        // fixed boundary
        return configVal;
    }

    // soft boundary (respecting out of range values)
    configVal = parseInt(configVal.substr(1));
    Math[type](configVal, ...series.map(ele => ele[type]));
}

@kalkih what do you think?

[Silencer2K]

Good idea. Now config looks much better: Screenshot

[maxwroc]

As @kalkih suggested it might be true by default

[maxwroc]

Looks perfect for me now but please update the doc. Mention there the ~ option in value

[kalkih]

Looks good, good idea with the ~ prefix, great job you two.

[ZeevoX]

It should probably be made clear in the README from which version onwards soft bounds are supported. As a new user I had no idea that soft bounds were newly introduced because it says from v0.2.3 and was wondering why they weren't working.