Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Diff aggregation #601

Merged
merged 3 commits into from
Jan 17, 2022
Merged

Diff aggregation #601

merged 3 commits into from
Jan 17, 2022

Conversation

mhspelt
Copy link
Contributor

@mhspelt mhspelt commented May 6, 2021

(paraphrased from #600)
Hi, this is my first pull request ever, so I hope I did everything right.
I have a sensor in HA that can go negative during the day (it measures net power usage taking solar into account) and I wanted to know the difference between the first reading of the day and the final reading of the day. So I added diff to calculate this (for monotonously increasing data the result is identical)

@OmgImAlexis
Copy link
Collaborator

@mhspelt please rebase.

@mhspelt
Copy link
Contributor Author

mhspelt commented May 25, 2021 via email

@kalkih kalkih changed the base branch from master to dev September 24, 2021 16:29
@kalkih kalkih added the feature request New feature or request label Sep 24, 2021
@kalkih
Copy link
Owner

kalkih commented Sep 24, 2021

Please add documentation for this: https://github.com/kalkih/mini-graph-card/tree/dev#aggregate-functions

@jlsjonas jlsjonas mentioned this pull request Jan 15, 2022
Copy link
Collaborator

@jlsjonas jlsjonas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mhspelt Could you please add documentation for this feature as requested?
Thanks for your contribution! (we'll take care of rebasing during merge, as we understand you're unfamiliar with the process)

@mhspelt
Copy link
Contributor Author

mhspelt commented Jan 17, 2022

Hi @jlsjonas, I've added and pushed to https://github.com/mhspelt/mini-graph-card
I don't really see the commit in this PR yet, does it synchronize automatically? Still not really getting git branches, but it's on the correct branch now,

src/graph.js Outdated Show resolved Hide resolved
@jlsjonas jlsjonas merged commit 4aa28fc into kalkih:dev Jan 17, 2022
jlsjonas added a commit that referenced this pull request Jan 22, 2022
* Add aggregation 'diff' (= last - first)

* Add `diff` to documentation

* Rewrite delta or diff if check for readability

Co-authored-by: Mischa <mspelt@outlook.com>
Co-authored-by: Jonas De Kegel <jonas@fluid.desi>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants