Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Add tap_action to the Main Card #174

Closed
stmrocket opened this issue Sep 29, 2019 · 9 comments
Closed

Feature Request: Add tap_action to the Main Card #174

stmrocket opened this issue Sep 29, 2019 · 9 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@stmrocket
Copy link

First, this card is exactly what I was looking for in a media player. It has been working well since I set it up.

Would it be possible to add tap_action (and ideally hold_action) parameters to the media player card itself? This would allow for triggering an action instead of the more-info pop-up.

Some background: I have been using pop-up card to show a custom card instead of the default more-info card on several minimalist players to save room but still give access to source and transport controls when needed. This card has now been deprecated and the replacement requires a service call to trigger the pop-up.

@kalkih kalkih added the enhancement New feature or request label Sep 29, 2019
@darkkatarsis
Copy link
Contributor

Yes, it would be great!

@kalkih kalkih added the good first issue Good for newcomers label Nov 8, 2019
@kalkih
Copy link
Owner

kalkih commented Nov 8, 2019

If anyone wanna help implement this feature:
I've implemented this in my other card and the implementation can be found here handleClick.js, we should be able to pretty much copy paste it into this project.

@crazytok
Copy link

crazytok commented Nov 8, 2019

+1 on this! I would really like to use this feature for redirection to another more advanced Music tab!

@stmrocket
Copy link
Author

Looking over the code, this looks like it should be simple to bring over. I'll work on it.

@kalkih
Copy link
Owner

kalkih commented Nov 8, 2019

Let me know if you need assistance 👍

@crazytok
Copy link

crazytok commented Nov 8, 2019

You guys are awesome!

@darkkatarsis
Copy link
Contributor

darkkatarsis commented Nov 18, 2019

@stmrocket And how about this functionality?

kalkih pushed a commit that referenced this issue Nov 22, 2019
* #174 Tap Action

* #174 code resolve

* code clean

* missing Action object options
@kalkih
Copy link
Owner

kalkih commented Dec 12, 2019

Now available in the latest release, thanks @darkkatarsis.

@kalkih kalkih closed this as completed Dec 12, 2019
@darkkatarsis
Copy link
Contributor

@kalkih Will it be very complicated to add hold action support?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

4 participants