Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Volume tear drop cut in half over slider #185

Closed
Merwenus opened this issue Nov 9, 2019 · 2 comments
Closed

Volume tear drop cut in half over slider #185

Merwenus opened this issue Nov 9, 2019 · 2 comments
Labels
bug Something isn't working

Comments

@Merwenus
Copy link

Merwenus commented Nov 9, 2019

Volume effect is cut half.
Tested in Firefox and Chrome.
Tested version 1.4.2 and 1.3.1
HA 101.3

The tear drop is a bit higher and visually cut in half.
https://i.imgur.com/3me33bF.png

No idea if it is HA or MMM problem, maybe someone can fix it.

@kalkih kalkih added the bug Something isn't working label Nov 13, 2019
@kalkih
Copy link
Owner

kalkih commented Nov 13, 2019

Definitely an issue with this card and not HA.
It's a matter of some CSS and maybe adding an additional container element to make sure we don't allow overflow of cover artwork (especially with card border-radius) and other stuff but still allow the volume pin to overflow.

kalkih added a commit that referenced this issue Dec 9, 2019
@kalkih
Copy link
Owner

kalkih commented Dec 12, 2019

Should be fixed in the latest release, might still occur if the mmp card is nested inside another card that doesn't allow overflow but I can't do anything about that.

@kalkih kalkih closed this as completed Dec 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants