Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deleted Line 303 #593

Merged
merged 1 commit into from
Feb 11, 2022
Merged

Deleted Line 303 #593

merged 1 commit into from
Feb 11, 2022

Conversation

DATAstrm
Copy link
Contributor

Line 303 is preventing shuffle button icon from scaling with "scale" option. Removing it allows resizing of shuffle button icon.

Testing was performed with the spotify integration enabled and the shuffle button shown.

Line 303 preventing shuffle button icon from scaling with "scale" option.  Removing it allows resizing of shuffle button icon.
@suneworld
Copy link

I can confirm this. While I wait for the merge: how do I remove line 303? I am unable to find the mentioned file.

@DATAstrm
Copy link
Contributor Author

DATAstrm commented Feb 7, 2022

All I did was delete the line after finding it in the js file.

@suneworld
Copy link

suneworld commented Feb 7, 2022 via email

@DATAstrm
Copy link
Contributor Author

DATAstrm commented Feb 7, 2022

You can just search for the code that was in the deleted line. I think it only appears once in the entire file.

@suneworld
Copy link

suneworld commented Feb 10, 2022

I tried deleting in the file without doing a full recompile. Did not work I'm afraid. But added the following to the card itself solved the issue:
style: .mmp-player .mmp-player__adds: mmp-media-controls: $: | ha-icon-button { --mdc-icon-size: 60px !important; }

@kalkih kalkih changed the base branch from master to dev February 11, 2022 16:55
@kalkih kalkih added the bug Something isn't working label Feb 11, 2022
@kalkih kalkih merged commit 3700828 into kalkih:dev Feb 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants