remove HAL traits (unneeded with updates to ht16k33) #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The fewer driver crates with opinions on which HAL library version to use, the better.
Solution
The trait supplied by this library does not perform IO. When (or if)
ht16k33relaxes the bounds, then this crate doesn't even need a dependency on a specific HAL.This change is dependent on
ht16k33merging jasonpeacock/ht16k33#22. Since this library is only manipulating the display buffer, the user will only need to agree with the HAL trait used inht16k33IO methods. (e.g. one fewer crate to patch)Notes
Cargo.tomlwill need to be edited when/ifht16k33removes HAL trait bounds from the non-IO methods (PR linked above) but it currently shows the version that is proposed (branch "data-only-methods" on my fork)