Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setup.py file #99

Closed
Sispheor opened this issue Nov 26, 2016 · 12 comments
Closed

setup.py file #99

Sispheor opened this issue Nov 26, 2016 · 12 comments
Milestone

Comments

@Sispheor
Copy link
Member

Create a setup.py file.
Almost done in the install_review branch.

This one need to:

  • install python libs
  • install entrypoints (/usr/bin/kalliope)
  • create /etc/kalliope
  • put a default settings.yml file in /etc/kalliope if not already present (do not override current user config)
  • put an hello world brain in /etc/kalliope
@Sispheor Sispheor added this to the v0.2 milestone Nov 26, 2016
@thomaspierson
Copy link
Contributor

@Sispheor , @LaMonF , I can try to make a new PR for this issue from dev branch and improving what we already did on the review_install branch. It's ok for you?

@Sispheor
Copy link
Member Author

Yes, thank you.

Keep in mind we need to keep a valid entry point for dev.

I also thing that the issue about /etc/kalliope should be done before as the setup.py will install kalliope in a reserved folder where the user should not insert or modify data in it.

@thomaspierson
Copy link
Contributor

Yes I'm agree that it will require #96 to be done first but I can start working on it and rebase my branch later when #96 will be done. What do you think?

@Sispheor
Copy link
Member Author

Ok !

@thomaspierson
Copy link
Contributor

thomaspierson commented Nov 27, 2016

Work in progress here :

Things done:

  1. Start a new branch from dev state.
  2. Cherry-pick and rework from the obsolete review_install branch.
  3. Add a valid entry point kalliope.py at the root of the project. Both entry point works correctly like we want in Entry points #98 .
  4. Make all current tests pass.

Things to do:

  1. Manage config stuff in /etc/kalliope but require Settings/brain/templates (user config) loaded from /etc/kalliope #96 .
  2. Adapt and update the install procedure.

I'm waiting for #96 to continue on this point.

@LaMonF LaMonF modified the milestones: v0.3, v0.2 Nov 27, 2016
@Sispheor
Copy link
Member Author

I've just cloned your repo @thomaspierson and installed kalliope with the setup.py. It looks good.
Thank you for you excellent job!

I propose to PR this in dev branch so I can start working on #96.

@thomaspierson
Copy link
Contributor

Sorry @Sispheor , I just see your comment. Thank you for your review!
I just submit the PR for the dev branch.

LaMonF added a commit that referenced this issue Nov 27, 2016
…_99_98

Move to python package standard with a setup.py file and 2 entrypoints. ( #99 #98 )
@Sispheor
Copy link
Member Author

Sispheor commented Dec 1, 2016

So, @LaMonF will check my PR soon. Once it's validated you can take the lead @thomaspierson .

The idea would be to have this tree in /etc/kalliope:

/etc/kalliope/
├── brains
│   └── say_hello.yml
├── brain.yml
├── settings.yml
└── trigger
    └── kalliope-FR-13samples.pmld
  • The main brain file would contain only the sub say_hello brain.
  • Say hello brain would contains 2 synaspes, one for saying hell in french and another one in english
  • The default settings would point the snowboy model in the trigger folder.

What do you think?

@LaMonF
Copy link
Member

LaMonF commented Dec 10, 2016

#134

@LaMonF LaMonF closed this as completed Dec 10, 2016
@thomaspierson
Copy link
Contributor

@LaMonF , @Sispheor, I can't see changes about the install of configs files in /etc/kalliope. Is anyone did it yet?
If not maybe we should reopen an issue about that? I still plan to do it but I just can't get the time until now sorry…

@Sispheor
Copy link
Member Author

We finally chose to not provide any configuration in /etc/kalliope. Kalliope will look into this folder during the loading but that's it.
Instead, we provide to users 2 starter configuration in separate repo. See the installation doc.

The user is free after that to place his configuration into /etc or not. We explain in settings the loading order.

@thomaspierson
Copy link
Contributor

thomaspierson commented Dec 10, 2016

Ok, maybe it's better like that.
Anyway, it's more the job of distros maintainers to provide packages which take care of that and of the deamon config too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants