Docker ci #246
Merged
Docker ci #246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yep.. it fails because when we do a PR instead of a push, Travis environment variables change. And so the wrong branch is cloned in the container. I'll try to fix that. |
|
@LaMonF it's fixed ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow Travis to test the code inside an Ubuntu 16.04 and Debian 8 container in order to Closes #101.
I've updated a test to be sure the singleton is cleaned before using it when loading a brain or settings.
Note: We cannot test the code inside a Raspbian image as the env on travis is x86_64 and Raspbian images need armv7.