-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use ispredicate(::Arbfunction) to return Bool from arbcall #59
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good! Would be good to also add some simple tests, should be easy since ispredicate
is self contained.
@kalmarek In which branch do you want to merge this by now? Shouldn't this be master? |
ced089e
to
402bd85
Compare
9615387
to
c8a1173
Compare
@Joel-Dahne I know it's post-factum, but could you produce a list with your (canonical ;) version of arb docs which functions are detected as predicates? I made this list locally and everything looked ok, but you never know ;) |
I looked through the functions detected as predicates and it seems fully correct! However it does miss some functions which do return a boolean, for example |
I think that the return value of see #62 |
This adds just predicate detection and uses it to turn the returned
int
toBool
. Arblib returns "success", hence non-zero output can be interpreted astrue