Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mk/renaming #22

Merged
merged 9 commits into from
Apr 7, 2021
Merged

Mk/renaming #22

merged 9 commits into from
Apr 7, 2021

Conversation

kalmarek
Copy link
Owner

@kalmarek kalmarek commented Apr 1, 2021

@fingolfin, @thofma

@codecov-io
Copy link

codecov-io commented Apr 1, 2021 •
edited
Loading

Codecov Report

Merging #22 (0067399) into main (10a138a) will increase coverage by 1.55%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #22      +/-   ##
==========================================
+ Coverage   84.84%   86.40%   +1.55%     
==========================================
  Files           3        3              
  Lines          99      103       +4     
==========================================
+ Hits           84       89       +5     
+ Misses         15       14       -1
Flag Coverage Δ
unittests 86.40% <100.00%> (+1.55%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/GroupsCore.jl 26.66% <ø> (ø)
src/group_elements.jl 98.11% <100.00%> (ø)
src/groups.jl 94.28% <100.00%> (+3.96%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 10a138a...0067399. Read the comment docs.

@thofma
Copy link

thofma commented Apr 1, 2021

Thanks!

fingolfin
fingolfin reviewed Apr 1, 2021
View reviewed changes
test/conformance_test.jl
@@ -177,12 +179,12 @@ function test_GroupElement_interface(g::GEl, h::GEl) where {GEl<:GroupElement}
@test similar(g) isa typeof(g)
end

one!, inv!, mul!, conj!, comm!, div_left!, div_right! = (
one!, inv!, mul!, conj!, commutator!, div_left!, div_right! = (
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So... to color the bike shed... it is inv, mul, div... why not expand those? Because Julia defines them, I guess... but then comm fits better into that sequence. OTOH if we only expand things that we add over Base, shouldn't we so it for all and also expand conj?

Don't get me wrong, I am not opposed, but I am confused: what's the rule here?

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tbh. I have no idea, but this change was requested by @thofma in #20 ...

@kalmarek
Copy link
Owner Author

kalmarek commented Apr 7, 2021

I just added a note on the need to implement Base.size if IteratorSize returns HasShape{N}(). @fingolfin when CI passes I'll bump version and merge this

@kalmarek kalmarek merged commit 731cb2f into main Apr 7, 2021
@kalmarek kalmarek deleted the mk/renaming branch April 7, 2021 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fingolfin fingolfin fingolfin left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Less abbreviations Ideas: Non-finitely presented groups
4 participants
@kalmarek @codecov-io @thofma @fingolfin