Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use AbstractPermutations.jl #37

Merged
merged 7 commits into from
Dec 4, 2023
Merged

use AbstractPermutations.jl #37

merged 7 commits into from
Dec 4, 2023

Conversation

kalmarek
Copy link
Owner

@kalmarek kalmarek commented Dec 1, 2023

as expected the port was easy enough and doesn't impair the performance ;)

Copy link

codecov bot commented Dec 1, 2023

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (773db9e) 96.90% compared to head (b0a09e2) 96.21%.

Files Patch % Lines
src/perm_group.jl 80.00% 3 Missing ⚠️
src/Perms/perm_images.jl 90.00% 2 Missing ⚠️
src/group_interface.jl 85.71% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #37      +/-   ##
==========================================
- Coverage   96.90%   96.21%   -0.70%     
==========================================
  Files          16       11       -5     
  Lines         775      607     -168     
==========================================
- Hits          751      584     -167     
+ Misses         24       23       -1     
Flag Coverage Δ
unittests 96.21% <92.85%> (-0.70%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kalmarek kalmarek linked an issue Dec 4, 2023 that may be closed by this pull request
@kalmarek kalmarek merged commit 06cea66 into master Dec 4, 2023
19 of 21 checks passed
@kalmarek kalmarek deleted the mk/AbstractPermutations branch December 4, 2023 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Making group actions broadcastable
1 participant