Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HTML5 Player does not call VPAID 'pauseAd' when pausing content #1586

Closed
ocundale opened this issue Mar 5, 2015 · 3 comments
Closed

HTML5 Player does not call VPAID 'pauseAd' when pausing content #1586

ocundale opened this issue Mar 5, 2015 · 3 comments

Comments

@ocundale
Copy link
Contributor

ocundale commented Mar 5, 2015

This issue can be seen on the test page here:
coullwebsdk.herokuapp.com/minimal-test.php

Wait for an overlay to appear, then pause player- Expected functionality is that the overlay should be hidden on pause and re-appear when you resume.
However, 'pauseAd' & 'resumeAd' are not currently called.

From VPAID spec:
"pauseAd is called to pause ad playback. The ad sends an AdPaused event when the
ad has been paused. resumeAd is called to continue ad playback following a call to pauseAd. The ad sends an AdPlaying event when the ad has resumed playing."
@amirch1
Copy link
Contributor

amirch1 commented Mar 9, 2015

Thanks! This will be added to the next player version (2.29)

@ocundale
Copy link
Contributor Author

ocundale commented Mar 9, 2015

Brill, let me know once you have a PR, I can test before merge if you like :)

@ocundale
Copy link
Contributor Author

This is now working in version 2.2.9. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ocundale @amirch1