New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mp4: parse udta stream names #1281
Conversation
Hi @JoelLinn, |
d40e966
to
732d166
Compare
Changed as requested |
I checked ffmpeg source - Unlike hdlr, there is no case of pascal string here, and also, it seems ffmpeg won't write any null characters on this string. |
732d166
to
d8bf931
Compare
special string handling removed |
One last comment, for consistency with the hdlr code, let's replace |
- Increases accessibility to the visually impaired by allowing multiple (audio) channels per language. - Stream names are usually (i.e. FFmpeg) saved in `udta` section as `name` atom - Configurable via `vod_parse_udta_name`, defaults to `Off` - Existing `hdlr` name parsing often just contains generic names, see kaltura#695 for previous discussion
d8bf931
to
8de18c5
Compare
👍 |
Merged, thanks! |
(audio) channels per language.
udta
node asname
atomvod_parse_udta_name
, defaults toOff
hdlr
name parsing often just contains generic names, seeis it possible to get audio label attribute from mp4 file in local mode? #695 for previous
discussion
I am assuming null terminated strings inside udta->name atom. I know that some formats (.mov ?) use pascal strings. At least FFmpeg uses null termination for mp4, please comment if you think pascal strings might be encountered and need to be addressed (similar to hdlr name is parsed)
If both
vod_parse_hdlr_name
andvod_parse_udta_name
areOn
,hdlr
will take precedence. I consider this an implementation detail and therefore did not specify this order in the documentation/Readme.md