IMAPlugin Unowned Self Crash Fix #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @TheoBendixson. Thank you for this contribution, we will look at it shortly. |
x-NR-x
approved these changes
Mar 25, 2019
noamtamim
pushed a commit
that referenced
this pull request
Apr 24, 2019
* IMAPlugin Unowned Self Crash Fix (#30) * Fem 2389 - Seeking to end, sometimes the post roll is not played (#31) * FEM-2389 Added logic to wait for the Mid-roll to play if exists before contentComplete is called so that the Post-roll can be played if exists. * FEM-2389 Added a check for a valid CuePoint. Code cleanup. * FEM-2467 Swift 4.2 (#32) * FEM-2467 Updated podspec swift to 4.2 Updated travis to Xcode 10.1 * FEM-2467 Swift 4.2 compilation fixes. * Fixed blocks using weak self. Swift 4.2 compilation fixes. * Removed cocoapods deprecated swift-version file. * Swift 4.2 upgrade with StrongSelf. * FEM-2465 Expose Creative ID and Advertiser Name (#34) * FEM-2465 Support addition of Creative ID and Advertiser Name * Add dependance to PlayKit v3.9.0 * Updated version to 1.4.0 (#35) * FEM-2478 Updated to Swift 5, fixed code accordingly. (#36) * FEM-2478 Updated to Swift 5, fixed code accordingly. Updated XCGLogger dependence to 7.0.0 * Version 1.5.0 * Travis: just lint
x-NR-x
added a commit
that referenced
this pull request
May 21, 2019
* develop: Updated version to 1.5.0 Travis: just lint FEM-2478 Updated to Swift 5, fixed code accordingly. (#36) Updated version to 1.4.0 (#35) FEM-2465 Expose Creative ID and Advertiser Name (#34) FEM-2467 Swift 4.2 (#32) Fem 2389 - Seeking to end, sometimes the post roll is not played (#31) IMAPlugin Unowned Self Crash Fix (#30) # Conflicts: # AdsEnabledPlayerController.swift # IMAPlugin.swift
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few months back, me and a few people on the MotorTrend team noticed a crash being reported on Crashlytics.
It was coming from this library in this file in the request timeout handler. I believe there was some kind of a race condition making it possible for the 'self' in the closure to be nil when the closure ran.
We made this change in a forked version of our PlayKit_IMA library, and the crash disappeared from Crashlytics, never to return again.
It appears as though your team has made similar changes to the iOS PlayKit library, fixing crashes that likely resulted from declaring the self in a capture list as unowned. Since self can be nil when the closure gets called, it should be declared weak in the capture list.
I just wanted to point out this issue on the PlayKit_IMA library and how our team fixed it.