Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support 360&VR #FEM-1107 #225

Merged
merged 18 commits into from
Oct 11, 2017
Merged

Support 360&VR #FEM-1107 #225

merged 18 commits into from
Oct 11, 2017

Conversation

ElizaSapir
Copy link

@ElizaSapir ElizaSapir commented Sep 26, 2017 •
edited
Loading

Description of the Changes

  • tags field attachment on OVPEntry request
  • missingDependency error code attachment under PKError
  • Reflecting core functions from internal to public under AVPlayerEngine
  • PKVRController attachment, will be used as VR controller
  • PlayerController now detects if content is VR or not and decides which player wrapper should be created.
  • New layer of wrappers AVPlayerWrapper & VRPlayerWrapper under player controller that used as relevant player engine wrapper.
    • There is DefaultPlayerWrapper that is created as an initial wrapper by PlayerController till media source type (VR/ simple) is detected.
  • New BasicPlayer protocol attachment that is inherited from Player & PlayerEngine protocols
  • VRData attachment
    • For now, this class is allocated and uses as an indicator when VR content is detected.
  • VRPlayerEngine attachment, this protocol exposes the VR API which will be implemented on separate VR repo.
  • replace MediaEntryProviderResponseDelegate with PKMediaEntryProviderResponseDelegate

Breaking Changes

  • Replace MediaSource with PKMediaSource
  • Replace MediaEntry with PKMediaEntry
  • Removing createPiPController since never tested
  • prepare now is throwble since player creation is postponed
  • seek now gets TimeInterval not CMTime

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

ElizaSapir added 9 commits July 20, 2017 14:10
@ElizaSapir ElizaSapir changed the title Fem 1107 Support 360&VR #FEM-1107 Oct 8, 2017
@ElizaSapir ElizaSapir self-assigned this Oct 9, 2017
gal-orlanczyk
gal-orlanczyk suggested changes Oct 10, 2017
View reviewed changes
Classes/Player/PlayerController.swift
@@ -211,12 +207,20 @@ class PlayerController: NSObject, Player {
//Assert.shouldNeverHappen();
}

public func getController(type: PKController.Type) -> PKController? {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add swifter method in addition with generics for swift users :)

@ElizaSapir ElizaSapir merged commit 19f6a98 into develop Oct 11, 2017
@ElizaSapir ElizaSapir deleted the FEM-1107 branch October 11, 2017 05:02
@ElizaSapir ElizaSapir mentioned this pull request Oct 15, 2017
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gal-orlanczyk gal-orlanczyk gal-orlanczyk approved these changes

Assignees

@ElizaSapir ElizaSapir

Labels
enhancement
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ElizaSapir @gal-orlanczyk