Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Time observation enhancements #231

Merged
merged 1 commit into from
Oct 26, 2017
Merged

Conversation

gal-orlanczyk
Copy link
Contributor

@gal-orlanczyk gal-orlanczyk commented Oct 17, 2017

Description of the Changes

  • Move observation from player engine to PlayerController in order to have a more general design, time observation was made to be used by every player.
  • Removed the ability to remove all periodic and boundary observers (only available for internal use).

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

* Move observation from player engine to PlayerController in order to have a more general design, time observation was made to be used by every player.
* Removed the ability to remove all periodic and boundary observers (only available for internal use).
@gal-orlanczyk gal-orlanczyk merged commit ede440e into develop Oct 26, 2017
@gal-orlanczyk gal-orlanczyk deleted the time-observation-enhancements branch October 26, 2017 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants