Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FEC-10866 seek to Live Edge API added #456

Merged
merged 1 commit into from
May 16, 2022
Merged

FEC-10866 seek to Live Edge API added #456

merged 1 commit into from
May 16, 2022

Conversation

chausov
Copy link
Contributor

@chausov chausov commented Apr 26, 2022

Solves FEC-10866
seek to Live Edge API added

@chausov chausov requested a review from x-NR-x April 26, 2022 23:06
x-NR-x
x-NR-x approved these changes May 3, 2022
View reviewed changes
Copy link
Collaborator

@x-NR-x x-NR-x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just update the description please.

Classes/Player/Protocols/BasicPlayer.swift
@@ -66,6 +66,9 @@ import Foundation
/// Send a seek action for the player.
@objc func seek(to time: TimeInterval)

/// Seek to the live edje.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
/// Seek to the live edje.
/// Seek to the live edge.

@chausov chausov merged commit bb4fdfe into develop May 16, 2022
@chausov chausov deleted the FEC-10866 branch May 16, 2022 08:33
x-NR-x added a commit that referenced this pull request Jun 8, 2022
@x-NR-x
Merge branch 'develop' into FEC-12251
8e54ffc 
* develop:
  FEC-12301 Expose AVPlayer preventsDisplaySleepDuringVideo (#458)
  FEC-10866 seek to Live Edge API added (#456)

# Conflicts:
#	Classes/Player/PKPlayerSettings.swift
#	Classes/Player/PlayerWrapper/AVPlayerWrapper.swift
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@x-NR-x x-NR-x x-NR-x approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@chausov @x-NR-x