Some tweaks for objective-c compatibility #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
reviewed
Feb 7, 2017
| PKLog.error("LocalDataStore not set") | ||
| return nil | ||
| throw NSError.init(domain: "LocalAssetsManager", code: -1, userInfo: nil) |
There was a problem hiding this comment.
Should we add centralized enum for domain names(maybe for codes also)? in case we will want to change in the future.
for example:
enum ErrorManager {
enum Domain: String {
case PlayKitReachability = "PlayKit.Reachability"
}
}
| @@ -128,21 +156,30 @@ public class LocalAssetsManager: NSObject { | |||
| } | |||
| } | |||
|
|
|||
| public protocol LocalDataStore { | |||
| @objc public protocol LocalDataStore: class { | |||
There was a problem hiding this comment.
I think ":class" is redundant here no? @objc makes the protocol for NSObject classes?
ghost
approved these changes
Feb 7, 2017
srivkas
added a commit
that referenced
this pull request
Feb 20, 2017
…EM-831-Changes * commit '6965fe817fe14075b66413ba27e7072c60d699d9': (65 commits) Simple OVP Session Provider (#90) #FEM-1117 (#88) #FEC-6462 #comment [~oren.melamed], do we know this issue doesn’t happen for Phoenix too? If you could get me a response sample for concurrency I could check. (#87) Added initObj key to the media mark request. It was missing. (#84) fix podspec Fec 6473 (#86) Small enhancement to player config (#82) Fixes memory leak created by Apple’s interoperability (#85) Update README.md Fix to prevent initializing `PlayKitManager` from outside in swift and objc (#81) Some tweaks for objective-c compatibility (#80) fixed issue with `KalturaLiveStatsPlugin` conforming to PKPlugin (#79) support wideinve privae pod Config API change and PKPlugin (#78) LocalAssetsManager: rename registerDownloadedAsset to assetDownloadFinished. (#77) bump v0.1.9 fix event observation on KalturaLiveStatsPlugin fix issues with tests after events change. (#74) bump v0.1.8 update podfile ... # Conflicts: # Example/PlayKit.xcodeproj/project.pbxproj # Example/Podfile # Example/Podfile.lock # Example/Tests/MediaEntryProvider/OVPMediaProviederTest.swift
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.