feat(FEC-13728): [Audio Player Improvements] Add support for download… #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
April 8, 2024 16:47
… plugin in audio player
SivanA-Kaltura
requested changes
Apr 11, 2024
| <title>Audio Player Plugin</title> | ||
| <script src="http://localhost:8086/kaltura-ovp-player.js"></script> | ||
| <script src="http://localhost:8081/playkit-downloads.js"></script> | ||
| <!-- <script src="https://unpkg.com/@playkit-js/kaltura-player-js@canary/dist/kaltura-ovp-player.js"></script>--> |
There was a problem hiding this comment.
remove comments if not used
| } | ||
| } | ||
|
|
||
| :global(.playkit-player.playkit-size-md), |
There was a problem hiding this comment.
does this override it for the current player only or for all players on the page ?
| <Tooltip label={moreIconTxt!}> | ||
| <A11yWrapper onClick={onClick}> | ||
| <button ref={moreButtonRef} className={`${ui.style.upperBarIcon} ${styles.morePluginsIcon}`} tabIndex={0} aria-label={moreIconTxt}> | ||
| <Icon id={`${'pluginName-123'}-upper-bar-manager`} path={ICON_PATH} viewBox={'0 0 32 32'} /> |
There was a problem hiding this comment.
use a more descriptive id name
added 4 commits
April 11, 2024 16:30
JonathanTGold
added a commit
to kaltura/playkit-js-ui
that referenced
this pull request
Apr 17, 2024
### Description of the Changes Add 'MiniAudioPreset handling #### Resolves FEC-13728 #### Related PR kaltura/playkit-js-audio-player#18 kaltura/playkit-js-downloads#48 --------- Co-authored-by: JonathanTGold <jonathan.gold@86@gmail.com>
JonathanTGold
added a commit
to kaltura/playkit-js-downloads
that referenced
this pull request
May 6, 2024
#48) …yer to interaction) ### Description of the Changes Expose the download overlay API (to enable Audio Player to interaction) ### Resolves FEC-13728 #### Related PR kaltura/playkit-js-audio-player#18 kaltura/playkit-js-ui#877 --------- Co-authored-by: JonathanTGold <jonathan.gold@86@gmail.com>
borhandarabi
pushed a commit
to TasvirChi/playchi-js-ui
that referenced
this pull request
May 15, 2024
### Description of the Changes Add 'MiniAudioPreset handling #### Resolves FEC-13728 #### Related PR kaltura/playkit-js-audio-player#18 kaltura/playkit-js-downloads#48 --------- Co-authored-by: JonathanTGold <jonathan.gold@86@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Changes
Add support for plugins integration
Resolves FEC-13728
Related PR
kaltura/playkit-js-ui#877
#19
kaltura/playkit-js-share#42
kaltura/playkit-js-downloads#48