feat(FEC-11666): Primary + Redirect token reports #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
OrenMe
reviewed
Nov 1, 2021
src/broadpeak.js
Outdated
| const updatedUrl = result.getURL(); | ||
| this.logger.debug('getUrl response', updatedUrl); | ||
| this.sourceChangeCallback(updatedUrl); | ||
| this.dispatchEvent(this.player.Event.SOURCE_URL_SWITCHED, {origUrl: playbackUrl, updatedUrl}); |
There was a problem hiding this comment.
lets use full names - originalUrl
RoyBregman
reviewed
Nov 2, 2021
RoyBregman
approved these changes
Nov 2, 2021
OrenMe
approved these changes
Nov 2, 2021
yairans
added a commit
to kaltura/playkit-js
that referenced
this pull request
Nov 2, 2021
expose new event - `SOURCE_URL_SWITCHED` Used by kaltura/playkit-js-broadpeak-smartlib#6 Solves FEC-11166
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Changes
fire
SOURCE_URL_SWITCHEDevent with the original URL and the updated oneDepends on kaltura/playkit-js#613
Solves FEC-11166
CheckLists