Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(FEC-11666): Primary + Redirect token reports #613

Merged
merged 2 commits into from
Nov 2, 2021
Merged

feat(FEC-11666): Primary + Redirect token reports #613

merged 2 commits into from
Nov 2, 2021

Conversation

yairans
Copy link
Contributor

@yairans yairans commented Nov 1, 2021 •
edited
Loading

Description of the Changes

expose new event - SOURCE_URL_SWITCHED

Used by kaltura/playkit-js-broadpeak-smartlib#6

Solves FEC-11166

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

@yairans yairans requested a review from a team November 1, 2021 11:47
@yairans yairans self-assigned this Nov 1, 2021
@yairans yairans mentioned this pull request Nov 1, 2021
Merged
5 tasks
@yairans yairans changed the title feat(FEC-11666): Primary + Redirect token reports #6 feat(FEC-11666): Primary + Redirect token reports Nov 1, 2021
@yairans yairans requested a review from OrenMe November 2, 2021 09:07
@yairans yairans merged commit 88f13b0 into master Nov 2, 2021
@yairans yairans deleted the FEC-11666 branch November 2, 2021 10:36
yairans added a commit to kaltura/playkit-js-broadpeak-smartlib that referenced this pull request Nov 2, 2021
@yairans
feat(FEC-11666): Primary + Redirect token reports (#6)
a440dd3 
fire `SOURCE_URL_SWITCHED` event with the original URL and the updated one

Depends on kaltura/playkit-js#613

Solves FEC-11166
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OrenMe OrenMe OrenMe approved these changes

Assignees

@yairans yairans

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yairans @OrenMe