Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(FEC-8749): expose IMA ad data #15

Merged
merged 1 commit into from
Jan 10, 2019
Merged

feat(FEC-8749): expose IMA ad data #15

merged 1 commit into from
Jan 10, 2019

Conversation

yairans
Copy link
Contributor

@yairans yairans commented Jan 10, 2019 •
edited
Loading

Description of the Changes

send the ad as a payload of AD_STARTED event

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

@yairans yairans self-assigned this Jan 10, 2019
@yairans yairans requested a review from dan-ziv January 10, 2019 09:33
@yairans yairans merged commit 06d5475 into master Jan 10, 2019
@yairans yairans deleted the FEC-8749 branch January 10, 2019 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dan-ziv dan-ziv dan-ziv approved these changes

Assignees

@yairans yairans

Labels
Priority: High Type: Feature
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@yairans @dan-ziv