fix: do not remove shaka event bindings on reset but in destroy (#189)

currently, we remove shaka event binding on reset so we dont get shaka events after detach/attach
kaltura · Mar 27, 2022 · 1378ba2 · 1378ba2
1 parent e02c629
commit 1378ba2
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/src/dash-adapter.js b/src/dash-adapter.js
@@ -826,6 +826,7 @@ export default class DashAdapter extends BaseMediaSourceAdapter {
       super.destroy().then(() => {
         DashAdapter._logger.debug('destroy');
         this._loadPromise = null;
+        this._adapterEventsBindings = {};
         this._reset()
           .then(resetResult => {
             this._isDestroyInProgress = false;
@@ -872,7 +873,6 @@ export default class DashAdapter extends BaseMediaSourceAdapter {
       this._eventManager.removeAll();
     }
     if (this._shaka) {
-      this._adapterEventsBindings = {};
       return this._shaka.destroy();
     }
     return Promise.resolve();