Skip to content

Commit

Permalink
fix(FEC-10590): remove the logic from dash adapter (#137)
Browse files Browse the repository at this point in the history
Issue: stall detector doesn't get the change of stallSkip after it loaded and stallSkip 0.1 cause freezes on old SmartTV.
Solution: Handle it on playkit kaltura/playkit-js#552
  • Loading branch information
Yuvalke committed Mar 15, 2021
1 parent 7687a43 commit 571ae30
Showing 1 changed file with 0 additions and 17 deletions.
17 changes: 0 additions & 17 deletions src/dash-adapter.js
Original file line number Diff line number Diff line change
Expand Up @@ -361,29 +361,12 @@ export default class DashAdapter extends BaseMediaSourceAdapter {
if (this._config.shakaConfig.useShakaTextTrackDisplay) {
this._shaka.setVideoContainer(Utils.Dom.getElementBySelector('.playkit-subtitles'));
}
this._maybeFixStallForSmartTV();
this._maybeSetFilters();
this._maybeSetDrmConfig();
this._shaka.configure(this._config.shakaConfig);
this._addBindings();
}

/**
* fix stall play promise rejected by seeking on the beginning instead of play pause
* @returns {void}
* @private
*/
_maybeFixStallForSmartTV(): void {
const defaultStallSkip = 0.1;
const currentStallSkip = this._shaka.getConfiguration().streaming.stallSkip;
Utils.Object.mergeDeep(this._config.shakaConfig, {streaming: {stallSkip: defaultStallSkip}});
this._eventManager.listenOnce(this._videoElement, EventType.PLAYING, () => {
if (currentStallSkip !== this._shaka.getConfiguration().streaming.stallSkip) {
this._shaka.configure({streaming: {stallSkip: currentStallSkip}});
}
});
}

/**
* get the redirected URL
* @param {string} url - The url to check for redirection
Expand Down

0 comments on commit 571ae30

Please sign in to comment.