fix(FEC-11082): DOM play error on SmartTV on when stall happen on the beginning #552
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… beginning Issue: pause happens after play comes from shaka, pause isn't neccesry here.
5 tasks
Yuvalke
changed the title
yairans
approved these changes
Mar 14, 2021
OrenMe
approved these changes
Mar 14, 2021
Yuvalke
added a commit
to kaltura/playkit-js-dash
that referenced
this pull request
Mar 15, 2021
Issue: stall detector doesn't get the change of stallSkip after it loaded and stallSkip 0.1 cause freezes on old SmartTV. Solution: Handle it on playkit kaltura/playkit-js#552
borhandarabi
pushed a commit
to TasvirChi/playchi-js-dash
that referenced
this pull request
May 14, 2024
Issue: stall detector doesn't get the change of stallSkip after it loaded and stallSkip 0.1 cause freezes on old SmartTV. Solution: Handle it on playkit kaltura/playkit-js#552
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Changes
Issue: shaka stall detector calling pause and play before first play promise resolved, it cause DOM exception and playback stop after this pause. flow is playback play() -> stall detector pause() play() -> play failed handler pause().
Solution: remove the pause from play failed handler since after play is failed browser handle it.
CheckLists