Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(FEC-10973): parse image tracks from dash manifest #131

Merged
merged 16 commits into from
Feb 15, 2021
Merged

feat(FEC-10973): parse image tracks from dash manifest #131

merged 16 commits into from
Feb 15, 2021

Conversation

dan-ziv
Copy link
Contributor

@dan-ziv dan-ziv commented Feb 8, 2021 •
edited by yairans
Loading

Description of the Changes

Shaka player does not support parsing of image type adaptation set, so need to create our own dedicated parser for this.
We will register to the response filter and extract the image tracks data in the following raw structure:

  • AdaptationSet
    • ?EssentialProperty
    • SegmentTemplate
    • List
      • ?EssentialProperty

See diagram for better understanding of the flow:

DashManifestParser flow (1)

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

This change is Reviewable

@dan-ziv dan-ziv self-assigned this Feb 8, 2021
yairans
yairans suggested changes Feb 11, 2021
View reviewed changes
src/parser/dash-manifest-parser.js Outdated Show resolved Hide resolved
src/parser/dash-manifest-parser.js Outdated Show resolved Hide resolved
src/parser/parser-utils.js Outdated Show resolved Hide resolved
src/parser/parser-utils.js Show resolved Hide resolved
src/parser/parser-utils.js Show resolved Hide resolved
@dan-ziv dan-ziv requested a review from yairans February 15, 2021 07:34
OrenMe
OrenMe suggested changes Feb 15, 2021
View reviewed changes
src/parser/parser-utils.js Outdated Show resolved Hide resolved
@dan-ziv dan-ziv requested a review from OrenMe February 15, 2021 08:39
OrenMe
OrenMe previously approved these changes Feb 15, 2021
View reviewed changes
yairans
yairans suggested changes Feb 15, 2021
View reviewed changes
src/dash-adapter.js Show resolved Hide resolved
@dan-ziv dan-ziv requested a review from yairans February 15, 2021 12:39
@dan-ziv dan-ziv merged commit c10efb8 into master Feb 15, 2021
@dan-ziv dan-ziv deleted the FEC-10973 branch February 15, 2021 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OrenMe OrenMe OrenMe approved these changes

@yairans yairans yairans approved these changes

@Yuvalke Yuvalke Awaiting requested review from Yuvalke

@RoyBregman RoyBregman Awaiting requested review from RoyBregman

Assignees

@dan-ziv dan-ziv

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dan-ziv @OrenMe @yairans