Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: do not remove shaka event bindings on reset but in destroy #189

Merged
merged 1 commit into from
Mar 27, 2022
Merged

fix: do not remove shaka event bindings on reset but in destroy #189

merged 1 commit into from
Mar 27, 2022

Conversation

yairans
Copy link
Contributor

@yairans yairans commented Mar 15, 2022 •
edited
Loading

Description of the Changes

currently, we remove shaka event binding on reset so we dont get shaka events after detach/attach

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

@yairans yairans requested a review from a team March 15, 2022 13:42
@yairans yairans self-assigned this Mar 15, 2022
@yairans yairans merged commit 1378ba2 into master Mar 27, 2022
@yairans yairans deleted the fix-reset branch March 27, 2022 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SivanA-Kaltura SivanA-Kaltura SivanA-Kaltura approved these changes

Assignees

@yairans yairans

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@yairans @SivanA-Kaltura