Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(FEC-7233): when parsing text tracks mark all as inactive #30

Merged
merged 2 commits into from
Oct 4, 2017
Merged

fix(FEC-7233): when parsing text tracks mark all as inactive #30

merged 2 commits into from
Oct 4, 2017

Conversation

dan-ziv
Copy link
Contributor

@dan-ziv dan-ziv commented Oct 3, 2017 •
edited
Loading

Description of the Changes

To support playkit default tracks flow we start shaka text tracks as inactive instead of take the active track from shaka (in case no track defined in the configuration of shaka it will be the first track in the manifest).

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

@dan-ziv dan-ziv self-assigned this Oct 3, 2017
@dan-ziv dan-ziv requested review from OrenMe and yairans October 3, 2017 20:55
@OrenMe
Copy link
Contributor

OrenMe commented Oct 3, 2017

@dan-ziv please add description

@dan-ziv dan-ziv merged commit de9b1e5 into master Oct 4, 2017
@dan-ziv dan-ziv deleted the FEC-7233 branch October 4, 2017 04:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OrenMe OrenMe OrenMe approved these changes

@yairans yairans Awaiting requested review from yairans

Assignees

@dan-ziv dan-ziv

Labels
Priority: Medium Type: Bug
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dan-ziv @OrenMe