Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(build): playkit core externals root value #42

Merged
merged 1 commit into from
Jan 28, 2018
Merged

feat(build): playkit core externals root value #42

merged 1 commit into from
Jan 28, 2018

Conversation

dan-ziv
Copy link
Contributor

@dan-ziv dan-ziv commented Jan 16, 2018

Description of the Changes

After changing the namespace to playkit.x need to update the externals root value of playkit core.

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

@dan-ziv dan-ziv self-assigned this Jan 16, 2018
@dan-ziv dan-ziv requested a review from OrenMe January 16, 2018 13:53
@OrenMe OrenMe changed the title fix(webpack): playkit core externals root value feat(webpack): playkit core externals root value Jan 21, 2018
@OrenMe OrenMe changed the title feat(webpack): playkit core externals root value feat(build): playkit core externals root value Jan 21, 2018
@OrenMe
Copy link
Contributor

OrenMe commented Jan 21, 2018

@dan-ziv fix tests

@dan-ziv dan-ziv merged commit 4395e42 into master Jan 28, 2018
@dan-ziv dan-ziv deleted the webpack-fix branch January 28, 2018 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OrenMe OrenMe OrenMe approved these changes

Assignees

@dan-ziv dan-ziv

Labels
Type: Feature
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dan-ziv @OrenMe