Skip to content

Commit

Permalink
chore: clean code
Browse files Browse the repository at this point in the history
  • Loading branch information
semarche-kaltura committed Jan 30, 2024
1 parent 8bead14 commit 8f33791
Show file tree
Hide file tree
Showing 6 changed files with 2,142 additions and 1,862 deletions.
27 changes: 0 additions & 27 deletions .github/workflows/run_canary_full_flow.yaml

This file was deleted.

3 changes: 0 additions & 3 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -51,16 +51,13 @@
"@types/node": "^14.11.2",
"@typescript-eslint/eslint-plugin": "^5.25.0",
"@typescript-eslint/parser": "^5.25.0",
"babel-loader": "^8.2.4",
"conventional-github-releaser": "3.1.3",
"css-loader": "^6.7.1",
"eslint": "^7.32.0",
"eslint-config-preact": "^1.3.0",
"eslint-plugin-mocha": "^10.1.0",
"eslint-plugin-prettier": "^4.0.0",
"prettier": "^2.6.2",
"promise-polyfill": "^8.2.3",
"regenerator-runtime": "^0.13.11",
"rimraf": "^5.0.5",
"sass": "^1.52.1",
"sass-loader": "^13.0.0",
Expand Down
9 changes: 0 additions & 9 deletions tsconfig.dev.json

This file was deleted.

35 changes: 16 additions & 19 deletions tsconfig.json
Original file line number Diff line number Diff line change
@@ -1,25 +1,22 @@
{
"compilerOptions": {
"target": "ES5",
"rootDir": ".",
"outDir": "build",
"preserveSymlinks": true,
"jsx": "react",
"jsxFactory": "h",
"jsxFragmentFactory": "Fragment",
"allowUnreachableCode": false,
"allowUnusedLabels": false,
"forceConsistentCasingInFileNames": true,
"lib": ["es2018", "dom"],
"allowJs": false,
"baseUrl": "..",
"experimentalDecorators": true,
"jsx": "react-jsx",
"jsxImportSource": "preact",
"module": "commonjs",
"noEmitOnError": true,
"noFallthroughCasesInSwitch": true,
"noImplicitReturns": true,
"pretty": true,
"moduleResolution": "Node",
"preserveSymlinks": true,
"skipLibCheck": true,
"sourceMap": true,
"strict": true,
"experimentalDecorators": true,
"downlevelIteration": true
"target": "ES5",
"types": ["node"],
"paths": {
"*": ["./src/*", "./node_modules/*"]
},
"lib": ["es2015", "dom"]
},
"include": ["src/**/*.tsx", "src/**/*.ts"],
"exclude": ["node_modules"]
"include": ["src/**/*.tsx", "src/**/*.ts", "node_modules/@playkit-js/kaltura-player-js/types.d.ts"]
}
48 changes: 22 additions & 26 deletions webpack.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -11,65 +11,61 @@ const plugins = [

module.exports = (env, { mode }) => {
return {
target: 'web',
entry: './src/index.ts',
optimization: {
minimize: mode !== 'development'
context: `${__dirname}/src`,
entry: {
'playkit-call-to-action': 'index.ts'
},
output: {
path: path.resolve(__dirname, 'dist'),
filename: '[name].js',
library: ['KalturaPlayer', 'plugins']
},
devtool: 'source-map',
module: {
rules: [
{
test: /\.tsx?$/,
loader: 'ts-loader',
options: { configFile: mode === 'development' ? 'tsconfig.dev.json' : 'tsconfig.json' },
options: {
configFile: 'tsconfig.json'
},
exclude: /node_modules/
},
{
test: /\.scss/,
test: /\.scss$/,
use: [
'style-loader',
{
loader: 'css-loader',
options: {
esModule: true,
modules: {
localIdentName: '[local]',
localIdentName: '[name]__[local]___[hash:base64:5]',
namedExport: true
}
}
},
{
loader: 'sass-loader',
options: {
sourceMap: mode === 'development'
sourceMap: true
}
}
]
}
]
},
resolve: {
extensions: ['.tsx', '.ts', '.js']
devServer: {
static: `${__dirname}/src`
},
output: {
filename: 'playkit-document-player.js',
path: path.resolve(__dirname, 'dist'),
clean: true
resolve: {
extensions: ['.tsx', '.ts', '.js'],
modules: [path.resolve(__dirname, 'src'), 'node_modules']
},
plugins: plugins,
externals: {
'@playkit-js/playkit-js': ['KalturaPlayer', 'core'],
'@playkit-js/kaltura-player-js': ['KalturaPlayer'],
preact: 'root KalturaPlayer.ui.preact'
},
devServer: {
static: {
directory: path.join(__dirname, 'src')
},
client: {
progress: true
}
preact: 'root KalturaPlayer.ui.preact',
'preact/hooks': 'root KalturaPlayer.ui.preactHooks',
'@playkit-js/kaltura-player-js': 'root KalturaPlayer'
}
};
};

0 comments on commit 8f33791

Please sign in to comment.