Skip to content

Commit

Permalink
Merge pull request #5 from kaltura/FEC-13682-change-plugin-config
Browse files Browse the repository at this point in the history
fix(FEC-13682): Change default plugin config values
  • Loading branch information
semarche-kaltura committed Feb 6, 2024
2 parents 68f47c8 + 3d193d5 commit 96da71c
Show file tree
Hide file tree
Showing 5 changed files with 59 additions and 45 deletions.
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -164,7 +164,7 @@ Finally, add the bundle as a script tag in your page, and initialize the player
>
> ##### Type: `boolean`
>
> ##### Default: `false`
> ##### Default: `true`
>

Expand Down
3 changes: 2 additions & 1 deletion cypress/e2e/document-player.cy.ts
Original file line number Diff line number Diff line change
Expand Up @@ -22,14 +22,15 @@ describe('Document player', () => {
});
it('should load document entry in playlist', () => {
mockKalturaBe();
loadPlaylist().then((kalturaPlayer) => {
loadPlaylist({}, { autoplay: false }).then((kalturaPlayer) => {
cy.get('[data-testid="doc-player-overlay"]').should('exist');
cy.wait('@mockThumb');
cy.get('.playkit-seek-bar').should('exist');
cy.get('.playkit-control-playlist-button').should('exist');
cy.get('.playkit-control-fullscreen').should('exist');
cy.get('.playkit-control-play-pause')
.should('exist')
.wait(1000)
.then(() => {
expect(kalturaPlayer.paused).to.equal(false);
});
Expand Down
7 changes: 4 additions & 3 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -58,8 +58,8 @@
"@babel/preset-typescript": "^7.23.3",
"@babel/runtime": "^7.23.8",
"@microsoft/api-extractor": "^7.39.1",
"@playkit-js/browserslist-config": "canary",
"@playkit-js/kaltura-player-js": "^3.17.9-canary.0-0c8731f",
"@playkit-js/browserslist-config": "1.0.8",
"@playkit-js/kaltura-player-js": "^3.17.10-canary.0-46423a2",
"@types/preact-i18n": "1.2.0",
"@typescript-eslint/eslint-plugin": "^6.19.0",
"@typescript-eslint/parser": "^6.19.0",
Expand All @@ -71,6 +71,7 @@
"eslint-config-preact": "^1.3.0",
"eslint-config-prettier": "^9.1.0",
"eslint-plugin-prettier": "^5.1.3",
"playwright-webkit": "^1.41.2",
"prettier": "^3.2.2",
"sass": "^1.69.7",
"sass-loader": "^13.3.3",
Expand All @@ -83,7 +84,7 @@
"webpack-dev-server": "^4.15.1"
},
"peerDependencies": {
"@playkit-js/kaltura-player-js": "^3.17.9-canary.0-0c8731f",
"@playkit-js/kaltura-player-js": "^3.17.10-canary.0-46423a2",
"@playkit-js/playkit-js": "^0.84.5-canary.0-df6fd72",
"@playkit-js/playkit-js-ui": "0.78.0-canary.0-b615ac6",
"preact": "10.4.6",
Expand Down
2 changes: 1 addition & 1 deletion src/doc-player.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ export const pluginName = 'playkit-js-document-player';
export class PlaykitJsDocumentPlugin extends core.BasePlugin {
static defaultConfig: DocumentPlayerConfig = {
basePreviewUrl: '',
downloadDisabled: false
downloadDisabled: true
};

private docOverlayDisposer: (() => void) | null = null;
Expand Down
90 changes: 51 additions & 39 deletions yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -1276,10 +1276,10 @@
resolved "https://registry.yarnpkg.com/@pkgr/core/-/core-0.1.1.tgz#1ec17e2edbec25c8306d424ecfbf13c7de1aaa31"
integrity sha512-cq8o4cWH0ibXh9VGi5P20Tu9XF/0fFXl9EUinr9QfTM7a7p0oTA4iJRCQWppXR1Pg8dSM0UCItCkPwsk9qWWYA==

"@playkit-js/browserslist-config@canary":
version "1.0.8-canary.0-f5791c1"
resolved "https://registry.yarnpkg.com/@playkit-js/browserslist-config/-/browserslist-config-1.0.8-canary.0-f5791c1.tgz#1bfea3cc970b6bc4b6d1696209f2bde72aeb3518"
integrity sha512-k3MsLvGuuf1Kben5GwkPx5weXEgYCgRPnt6ApMJ3y80paY/obU3DC+lmfeert/I2IEzQBlPWMVvtZKQH8KG9/w==
"@playkit-js/browserslist-config@1.0.8":
version "1.0.8"
resolved "https://registry.yarnpkg.com/@playkit-js/browserslist-config/-/browserslist-config-1.0.8.tgz#735256ba560063d397d4b8776acb865e8697a287"
integrity sha512-BeiDM72c6GP8dZ6b2qScEpxT4sGECIJzjVGsanaTvXeFOkw3MoplAyz6HPKdrcLmidcinSl4yna5Yc9/ObwZow==

"@playkit-js/common@^1.5.4":
version "1.5.4"
Expand All @@ -1290,33 +1290,43 @@
classnames "^2.3.2"
linkify-it "^4.0.1"

"@playkit-js/kaltura-player-js@^3.17.9-canary.0-0c8731f":
version "3.17.9-canary.0-0c8731f"
resolved "https://registry.yarnpkg.com/@playkit-js/kaltura-player-js/-/kaltura-player-js-3.17.9-canary.0-0c8731f.tgz#10884e7ba6961e3f6f30acb13e031d88a47f235e"
integrity sha512-wAjBDdILYX6Fvei2QYA/h88sIP6O/C1FdRxbZ3XRIlQHVV/azHNyOoUi0l1Cl5QXdTFX0CIQkaEoBrgZ/9QHww==
"@playkit-js/kaltura-player-js@^3.17.10-canary.0-46423a2":
version "3.17.10-canary.0-46423a2"
resolved "https://registry.yarnpkg.com/@playkit-js/kaltura-player-js/-/kaltura-player-js-3.17.10-canary.0-46423a2.tgz#5a6f420eda753135de609c670e28684a15bde804"
integrity sha512-pAqkdua9son0kVDqXnmwOlodFs2k86aUXjODireXeWVOWy1JGfT8+56yOOef+8A8W2Tnrl7g9JxOhkkXk71A7g==
dependencies:
"@playkit-js/playkit-js" latest
"@playkit-js/playkit-js-dash" latest
"@playkit-js/playkit-js-hls" latest
"@playkit-js/playkit-js-providers" canary
"@playkit-js/playkit-js-ui" canary
"@playkit-js/playkit-js" "0.84.5"
"@playkit-js/playkit-js-dash" "1.36.2"
"@playkit-js/playkit-js-hls" "1.32.11"
"@playkit-js/playkit-js-providers" "2.40.3"
"@playkit-js/playkit-js-ui" "0.78.0"
hls.js "1.4.11"
shaka-player "4.7.0"

"@playkit-js/playkit-js-dash@latest":
version "1.36.1"
resolved "https://registry.yarnpkg.com/@playkit-js/playkit-js-dash/-/playkit-js-dash-1.36.1.tgz#14f423cc7b12eb4cbf1f89c31e5a889a68a83f6e"
integrity sha512-8qne4uLCLQ+Oai0m9mVZNpHtdg5cjciU/2oJ/afCU3BUOQJs5U+jZ8NoiPcPWIyWabbZvUy0oKoiR4UT4EywWQ==
"@playkit-js/playkit-js-dash@1.36.2":
version "1.36.2"
resolved "https://registry.yarnpkg.com/@playkit-js/playkit-js-dash/-/playkit-js-dash-1.36.2.tgz#9321960db414008a4697b3545950445141161958"
integrity sha512-dE3PLnhJ3haM1pyrjDg+VE2qYHrSrop0U1jV1R8c0SJ9vLLtFQehlQlQ4F/h0oGLloqbihqvs+cT4mlWSfbOJA==

"@playkit-js/playkit-js-hls@1.32.11":
version "1.32.11"
resolved "https://registry.yarnpkg.com/@playkit-js/playkit-js-hls/-/playkit-js-hls-1.32.11.tgz#0d4d514750a660e9899d04e97482af6311355707"
integrity sha512-YWhFAYeBpONeENRQbmm6901FtkT4vwzu8O5mzrrty7TUGR3zXpBGszul1bngAZQWS6UZ5vpuvAuLSz+37BFUpg==

"@playkit-js/playkit-js-hls@latest":
version "1.32.10"
resolved "https://registry.yarnpkg.com/@playkit-js/playkit-js-hls/-/playkit-js-hls-1.32.10.tgz#7320c02011f6705c21c9062c3e416bf2e2bc80b0"
integrity sha512-YTk4lXvyUurSfY9YJNVvQqVL7u4bazgygJ8QvnpyRe64PBYb31I8g6GdXjPsBy/Kia0xPc4Bts5w8lEOICiJoQ==
"@playkit-js/playkit-js-providers@2.40.3":
version "2.40.3"
resolved "https://registry.yarnpkg.com/@playkit-js/playkit-js-providers/-/playkit-js-providers-2.40.3.tgz#d6da4e07711b3fa5a9d650e0752018584b71f5fe"
integrity sha512-6xfG+jhNqOCoPcjI5C+h6/SVS+RV6IObiBiQ6/TtP+FEZz+3lyg1D7R6kZMoUGB02ris1ODI954IAxngFdEaDA==

"@playkit-js/playkit-js-providers@canary":
version "2.40.3-canary.0-442924e"
resolved "https://registry.yarnpkg.com/@playkit-js/playkit-js-providers/-/playkit-js-providers-2.40.3-canary.0-442924e.tgz#d04625b78668c6614893222513458c2de823e5f9"
integrity sha512-8XBFfD3c01wjqNaud7it+k5mVq1b6g62yo5FNi+PAApkXtOaSQxItHt3NuJQIY2zjxx/XLzxRpbI2cpx66d3FA==
"@playkit-js/playkit-js-ui@0.78.0":
version "0.78.0"
resolved "https://registry.yarnpkg.com/@playkit-js/playkit-js-ui/-/playkit-js-ui-0.78.0.tgz#263539e8a448f312c19667608a434eef1e7761f6"
integrity sha512-keBkyzg8FtmmvWa+sA/6vpgYBCFGMcreqZ6AYPueOc4zbhOI26UBfMR2JS84rY4QIujv0E06j5Ict5YRGwvlDw==
dependencies:
preact "10.4.6"
preact-i18n "2.0.0-preactx.2"
react-redux "7.2.1"
redux "4.0.5"

"@playkit-js/playkit-js-ui@^0.77.10":
version "0.77.15"
Expand All @@ -1328,20 +1338,10 @@
react-redux "^7.2.0"
redux "^4.0.5"

"@playkit-js/playkit-js-ui@canary":
version "0.78.0-canary.0-b615ac6"
resolved "https://registry.yarnpkg.com/@playkit-js/playkit-js-ui/-/playkit-js-ui-0.78.0-canary.0-b615ac6.tgz#891368c1c6341ff37e8acab19f10b3cf2da5c7db"
integrity sha512-EHe+Rug2vKXWntql3Oz+AhcaNXu30o3zrcAkSkiXP0PoMSfXObGvHO+KIMAhTeOvm4vjX4gV5XgnX3PFahLeLA==
dependencies:
preact "10.4.6"
preact-i18n "2.0.0-preactx.2"
react-redux "7.2.1"
redux "4.0.5"

"@playkit-js/playkit-js@latest":
version "0.84.4"
resolved "https://registry.yarnpkg.com/@playkit-js/playkit-js/-/playkit-js-0.84.4.tgz#b763b827d6ca35118641d3ab965259d5167ede06"
integrity sha512-KtK9vvdxo1OaLOSDZcYXIU8ao9zRRCEBxyO8DsBsCqJTT+SHktM1GwdYV3gQmKWrvdJDMKSrQA0Pe2XAYUQCKA==
"@playkit-js/playkit-js@0.84.5":
version "0.84.5"
resolved "https://registry.yarnpkg.com/@playkit-js/playkit-js/-/playkit-js-0.84.5.tgz#df4558bc05f6bdc576de3d2e6ff9d576dfcb1e9e"
integrity sha512-YtUEeiSwQoEeXG9wX93p04KuKiQB06NoHLNkQs2rPXn1xgAPoObJay0z3xu+d0xVwpjMd1NI6K4dJ2VHdUR8Rw==
dependencies:
js-logger "^1.6.0"
ua-parser-js "^1.0.36"
Expand Down Expand Up @@ -5566,6 +5566,18 @@ pkg-dir@^7.0.0:
dependencies:
find-up "^6.3.0"

playwright-core@1.41.2:
version "1.41.2"
resolved "https://registry.yarnpkg.com/playwright-core/-/playwright-core-1.41.2.tgz#db22372c708926c697acc261f0ef8406606802d9"
integrity sha512-VaTvwCA4Y8kxEe+kfm2+uUUw5Lubf38RxF7FpBxLPmGe5sdNkSg5e3ChEigaGrX7qdqT3pt2m/98LiyvU2x6CA==

playwright-webkit@^1.41.2:
version "1.41.2"
resolved "https://registry.yarnpkg.com/playwright-webkit/-/playwright-webkit-1.41.2.tgz#72e69f2189b5b7eb4753779e1556299d8009d314"
integrity sha512-fkQC7Tz64V9Wi2mJa9IIQrgoqkEcVcQPz1uR2j+MIkZBfEj8i3A9C61A0V3k7rHuOw7veP9SwyAxi215qfnTOg==
dependencies:
playwright-core "1.41.2"

postcss-load-config@^3.1.4:
version "3.1.4"
resolved "https://registry.yarnpkg.com/postcss-load-config/-/postcss-load-config-3.1.4.tgz#1ab2571faf84bb078877e1d07905eabe9ebda855"
Expand Down

0 comments on commit 96da71c

Please sign in to comment.