fix(FEC-9523): add attach detach implemention #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add attach detach as exist in HTML5 to remove the source and reload it after
yairans
suggested changes
Dec 25, 2019
yairans
suggested changes
Dec 25, 2019
| */ | ||
| attachMediaSource(): void { | ||
| this.attach(); | ||
| this._startTimeAttach = this._lastTimeDetach; |
There was a problem hiding this comment.
clean this._startTimeAttach on destroy (change media)
OrenMe
previously approved these changes
Dec 26, 2019
yairans
previously approved these changes
Dec 29, 2019
yairans
suggested changes
Dec 30, 2019
src/flashhls-adapter.js
Outdated
| @@ -92,6 +106,17 @@ class FlashHLSAdapter extends FakeEventTarget { | |||
| if (this._el && this._el.parentNode) { | |||
| this._el.innerHTML = ''; | |||
| } | |||
| this._startTimeAttach = NaN; | |||
| this._lastTimeDetach = NaN; | |||
| delete this._api; | |||
There was a problem hiding this comment.
Suggested change
| delete this._api; | |
| this._api = null; |
Just change the type to ?FlashAPI
yairans
approved these changes
Dec 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Changes
for reloading media add attach detach implemention.
Simulate event as exist in HTML5 on destroy.
CheckLists