Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(FEC-10686): move startTime config from playback to sources #128

Merged
merged 1 commit into from
Jan 14, 2021

Conversation

dan-ziv
Copy link
Contributor

@dan-ziv dan-ziv commented Jan 13, 2021

Description of the Changes

move startTime to the sources config so it will take place only on the a specific source.

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

@dan-ziv dan-ziv self-assigned this Jan 13, 2021
Copy link
Contributor

@OrenMe OrenMe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dan-ziv is it possible to set this later and not in hls new instance creation? sounds more reasonable to do this

@dan-ziv
Copy link
Contributor Author

dan-ziv commented Jan 13, 2021

@OrenMe If you remember we did this optimization along time ago since we wanted to use the hls config to achieve chunk downloading from the startTime point. The other option is to seek to the start point and we manage this in the load() as well (in case we didn't get startTime earlier).

@OrenMe
Copy link
Contributor

OrenMe commented Jan 13, 2021

I actually wrote this and then so the old PR and approved - but forgot to delete the comment :-)

@dan-ziv dan-ziv merged commit b24f0fd into master Jan 14, 2021
@dan-ziv dan-ziv deleted the FEC-10686 branch January 14, 2021 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants