feat(FEC-13683): Pre/Post simulive analytics reporting #161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SivanA-Kaltura
requested review from
MosheMaorKaltura,
semarche-kaltura,
JonathanTGold and
lianbenjamin
semarche-kaltura
approved these changes
Mar 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Changes
Add sourceEntryId and playbackMode to VIEW event model
Note that this does not handle sending an event only once if we seek back to a previous portion of the simulive. If we want to do that, we need to understand how to identify that we have already seen this portion - by entry id ? (and then what if we have the same entry id multiple times in the simulive playlist) ?
Resolves FEC-13683
CheckLists