Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(FEC-13892): slate plugin| KMS edit page "add/Cancel" presenters buttons appears one above each other instead of next to each other #12

Merged
merged 3 commits into from
Apr 28, 2024

Conversation

SivanA-Kaltura
Copy link
Contributor

Description of the Changes

Issue - Similar to kaltura/playkit-js-document-player#7, unscoped css classes from common can cause issues if the embedding page contains an element with the same class

Fix - Add a scope prefix to the css classes of the plugin

Resolves FEC-13892

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

@SivanA-Kaltura SivanA-Kaltura merged commit 761e49c into master Apr 28, 2024
4 checks passed
@SivanA-Kaltura SivanA-Kaltura deleted the FEC-13892 branch April 28, 2024 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants