Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force KMC HTTPS, permission selection logic #1722

Closed
jpluijmers opened this issue Sep 29, 2014 · 3 comments
Closed

Force KMC HTTPS, permission selection logic #1722

jpluijmers opened this issue Sep 29, 2014 · 3 comments

Comments

@jpluijmers
Copy link

On our new Kaltura IX server I disabled Force KMC Https for our partner 102. However this did not have the intended effect. After doing some debugging I found the following lines in the PermissionPeer class (kmc module):

$permission = self::getByNameAndPartner($permissionName, array($partnerId, PartnerPeer::GLOBAL_PARTNER));

This includes the global partner (0) in the scanned permissions. However, in the getByNameAndPartner class the following sorting criteria is applied:

$c->addAscendingOrderByColumn(PermissionPeer::STATUS);

This in effect says: Always select Permission:ACTIVE over Permission:Blocked or Permission: Deleted. This way Active settings of the PartnerPeer::GLOBAL_PARTNER always prevail over partner specific settings. Is this intended behavior? And if it is, how do you change partner specific permissions?

I would suggest to add a second order column on partnerid, descending. This makes sure concrete partner rules are read first, while not breaking the multiple permissions case.

permission issue

@jpluijmers
Copy link
Author

After a quick search, this Behaviour also affects a lot of other locations.

@jpluijmers
Copy link
Author

I implemented the following changes on my server #1725

This fixes some of the issue for me.

@jessp01
Copy link

jessp01 commented Jan 22, 2016

Closing in light of #1725 (comment)

@jessp01 jessp01 closed this as completed Jan 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants